Non-functionality section #infragram #322 fixed#328
Non-functionality section #infragram #322 fixed#328stylebytemi wants to merge 1 commit intopubliclab:mainfrom
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
|
|
Hi, would you be able to show a screenshot of before/after? Thank you! |
|
@jywarren Hello, I'm sorry for the late reply. Trust you're having a great weekend. Kindly view screenshots to show what the before and after looks like |
| </div> | ||
| </div> | ||
|
|
||
| <div class="zone last" id="save-zone" style="display:none;"> |
There was a problem hiding this comment.
Ah, i see! Thank you @stylebytemi however one reason we have the buttons hidden initially is because before you begin uploading something, there is nothing to save, so we thought it best to hide them. An alternative could be to have them present but greyed out, but it still adds some perhaps unnecessary clutter to the page before those buttons can even be used. What do you think?
There was a problem hiding this comment.
Hello @jywarren, I assume a design proposal to solve the unnecessary clutter has been raised multiple times. However, I will suggest we leave it displayed to avoid confusion for users. My design suggestion would also be that of others which is to use a bootstrap property such as dropdown for clearer display. we can also use react routing and give each column(Div) used in toolbar a new tag which directly links to a clearer and well detailed page. I'm sorry for the late reply. Thanks for your time.
2 participants
Hello @TildaDares @jywarren , I edited line 79 by adding display flex and justify content space evenly, 168 by removing display none and I changed line 170-172 to 170-174 by creating a Div, giving the Div a class lastzone and styling (display flex and justify content space evenly), I also changed the size of the button from large to small.
Kindly review the changes. Thanks.